Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala ......................................................................
Patch Set 16: (2 comments) The build is unblocked so you can try to get this in, but I think you'll have to rebase and I'm not sure if there will be any conflicts. http://gerrit.cloudera.org:8080/#/c/4047/16/fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java: PS16, Line 29: AnalyzesOk("upsert into table functional_kudu.testtbl values(1, 'a', 1)"); : AnalyzesOk("upsert into table functional_kudu.testtbl(id) values(1)"); : AnalyzesOk("upsert into table functional_kudu.testtbl values(1, 'a', 1), " + : "(2, 'b', 2), (3, 'c', 3)"); 1. coverage of all data types 2. cols list in different order from the tbl PS16, Line 33: // SELECT clause coverage of all data types -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df5cea36b642e267f85ff6b163f3dd96b8386e9 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
