Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4384: NPE when cols list has trailing comma ......................................................................
IMPALA-4384: NPE when cols list has trailing comma The changes to introduce new PRIMARY KEY syntax allowed for a table definition to have a list of cols, optionally followed by a PRIMARY KEY clause. However, this rule was broken and would allow for the list of columns followed by a trailing comma. [localhost:21000] > create table foo (id int, x int,); Query: create table foo (id int, x int,) ERROR: AnalysisException: null CAUSED BY: NullPointerException: null Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760 Reviewed-on: http://gerrit.cloudera.org:8080/4869 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Internal Jenkins --- M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/ParserTest.java 2 files changed, 4 insertions(+), 10 deletions(-) Approvals: Matthew Jacobs: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc394dd7e687b501ae7887a51bed2f441d562760 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]>
