Alex Behm has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4911/1/be/src/exec/kudu-table-sink.h File be/src/exec/kudu-table-sink.h: Line 50: /// result in the sink returning an error status. The first non-ignored error is returned results Line 53: /// TODO: Handle other data/constraint-violation errors as ignored, e.g. null in null col e.g. null in non-nullable col http://gerrit.cloudera.org:8080/#/c/4911/1/fe/src/main/java/org/apache/impala/planner/KuduTableSink.java File fe/src/main/java/org/apache/impala/planner/KuduTableSink.java: Line 60: if (sinkOp_ == Op.INSERT) { remove -- To view, visit http://gerrit.cloudera.org:8080/4911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83b5beaa982d006da4997a2af061ef7c22cad3f1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
