Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL ......................................................................
Patch Set 4: (3 comments) Thanks for the review. Please see patch set 4. http://gerrit.cloudera.org:8080/#/c/4951/2/tests/comparison/db_connection.py File tests/comparison/db_connection.py: PS2, Line 797: r > why 3? Done http://gerrit.cloudera.org:8080/#/c/4951/2/tests/comparison/tests/test_cursor.py File tests/comparison/tests/test_cursor.py: PS2, Line 43: class, > class Done Line 172: def test_postgres_table_reading(postgresql_cursor, sql_primary_key_map): > Are we connecting to a real Postgres instance in this test? If so, where do Done -- To view, visit http://gerrit.cloudera.org:8080/4951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I447f022e2dc3d4fc8373b7f388c7875a869921b8 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
