Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. ......................................................................
IMPALA-3586: Clean up union-node.h/cc to enable improvements. This patch does not address IMPALA-3586, but it cleans up the code in union-node.h/cc to make it easier to implement those perf improvements. The major simplification is to remove conjunct evaluation since the planner does not assigns conjuncts to a union-node anymore. Conjuncts are always pushed to the union operands. Change-Id: Ia5fc23985e8d51acb8a6920717ce4e2f0254fe70 Reviewed-on: http://gerrit.cloudera.org:8080/4817 Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/union-node.cc M be/src/exec/union-node.h 2 files changed, 95 insertions(+), 133 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5fc23985e8d51acb8a6920717ce4e2f0254fe70 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins
