Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4435: Fix in-predicate-benchmark linking by moving templates ......................................................................
IMPALA-4435: Fix in-predicate-benchmark linking by moving templates In C++ (without export, which was removed in C++11), templates definitions (and not just declarations) must be in headers in order to be implicitly instantiated by callers. in-predicate-benchmark was http://gerrit.cloudera.org:8080/4758; this patch fixes the linker errors that were caused in some build modes by #including only the template declarations. Change-Id: Ie95ec71242b97f28c68e37d6f44956f2eeff8105 Reviewed-on: http://gerrit.cloudera.org:8080/4966 Reviewed-by: Jim Apple <[email protected]> Tested-by: Internal Jenkins --- M be/src/exprs/in-predicate-ir.cc M be/src/exprs/in-predicate.h 2 files changed, 114 insertions(+), 113 deletions(-) Approvals: Jim Apple: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95ec71242b97f28c68e37d6f44956f2eeff8105 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
