Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 1903: // TODO: call this as soon as it's clear that we won't reference the state removed. http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/plan-fragment-executor.h File be/src/runtime/plan-fragment-executor.h: Line 107: /// TODO: remove desc_tbl parameter once we do a per-query exec rpc (and we removed http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: Line 82: // TODO: destroy thread removed http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/query-exec-mgr.h File be/src/runtime/query-exec-mgr.h: Line 67: boost::mutex qs_map_lock_; removed http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 21: removed http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/service/impala-internal-service.cc File be/src/service/impala-internal-service.cc: Line 58: return; removed -- To view, visit http://gerrit.cloudera.org:8080/4418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I962ae6b7cb7dc0d07fbb8f70317aeb01d88d400b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
