Tim Armstrong has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes ......................................................................
Patch Set 10: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/4838/8/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: Line 1030: // significant bits overlap in memory. > I guess these should really have the LITTLE_ENDIAN checks too, right? Reworded the comment to be less little-endian specific. I think if we were to port this to big-endian, we'd add padding to DecimalVal so that the least significant bits lined up (which means the field offsets would be different). I don't think this code would have to change. -- To view, visit http://gerrit.cloudera.org:8080/4838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c3ed8c9d7a61e94a9b9d6c316e8a53d9ff6c24 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
