Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 9: The reason the GVO failed was the change in this patch that always calls QuerySchedule::set_is_admitted(true) for query schedules that don't go through AdmissionController::AdmitQuery. This was causing AdmissionController::ReleaseQuery to try to release queries that had never been subject to admission control, resulting in a crash. Originally, this was fine because the only condition where AdmitQuery wouldn't be called was when FLAG_disable_admission_control was false, which would also prevent ReleaseQuery from being called. However, a recent change added 'is_mt_execution' as a condition for skipping AdmitQuery but not as a condition for skipping ReleaseQuery, leading to the crash. Also originally, setting is_admitted to true when FLAG_disable_admission_control to true was necessary as we were relying on QuerySchedule::is_admitted to differentiate queries that were not scheduled/queued/etc, even when admission control is off. With the change to just using the query event log for differentiating not scheduled/queued/etc. states, this is no longer necessary, so to fix the crash I just removed it. -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: No
