Alex Behm has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4863/6/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: Line 912: partition (year, month) /*+ clustered */ > Done. I added a test and a DCHECK in HdfsTableSink::WriteClusteredRowBatch( We could add warning when inserting into an unpartitioned table with a clustered hint. Not in this patch, please. http://gerrit.cloudera.org:8080/#/c/4863/7/tests/query_test/test_insert.py File tests/query_test/test_insert.py: Line 112: def test_insert_test(self, vector): > This makes it possible to test only "insert.test" by specifying "-k test_in Sorry missed that in the commit msg. Works for me. http://gerrit.cloudera.org:8080/#/c/4863/7/tests/query_test/test_insert_behaviour.py File tests/query_test/test_insert_behaviour.py: Line 534: insert_stmt = """insert into {0} partition(l_returnflag) /*+ clustered */ select > No, it doesn't make any assumptions. I added the hint. I think it does make an assumption. If for whatever reason this plan switched to "noshuffle", we'd get more files and fail this test. -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
