Dan Hecht has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles ......................................................................
Patch Set 1: Code-Review+2 I see. Since we're going to have this extra layer eventually anyway (when using the builder as a true sink) and it seems it'll be simpler that way, consider doing that alternative. But I don't feel too strongly about it, I'm also okay with this fix in the meantime. -- To view, visit http://gerrit.cloudera.org:8080/4969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa5db623a84c47d5904033ec26aece74f500a2c9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
