Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5000
Change subject: IMPALA-4446: expr-test fails under ASAN ...................................................................... IMPALA-4446: expr-test fails under ASAN Various places in the LikePredicate code assumed StringVal is null-terminated. There is no such guarantee. By coincidence string literals were sometimes backed by std::string storage that was null-terminated, so this bug was latent until recently. Testing: Was able to reproduce the failure locally under ASAN, now the test passes. Running the full ASAN tests to verify, but putting this up for review first to unbreak the build sooner. Change-Id: I0ac10d34dd6463ab52e41de1002ef065cfe63a20 --- M be/src/exprs/like-predicate.cc 1 file changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/5000/1 -- To view, visit http://gerrit.cloudera.org:8080/5000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0ac10d34dd6463ab52e41de1002ef065cfe63a20 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
