Tim Armstrong has posted comments on this change. Change subject: IMPALA-4433: Fix undefined NDV calculations ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Would be good to have someone else take a look in case there might be other consequences for tests. http://gerrit.cloudera.org:8080/#/c/5004/1/be/src/udf_samples/hyperloglog-uda.cc File be/src/udf_samples/hyperloglog-uda.cc: PS1, Line 81: (sizeof(hash_value) * CHAR_BIT - HLL_PRECISION)); : dst->ptr[idx] = ::max(dst->ptr[idx], first_one_bit); > It's in Impala proper, while it seems like the non-test files in this direc Oops, thought I deleted this comment (I realised that point halfway through writing it) -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
