Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4985/1/be/src/exec/data-sink.cc File be/src/exec/data-sink.cc: Line 161: ss << "NumRowErrors: " << stats.kudu_stats.num_row_errors << endl; > Agree that misinformation is worse. Can you add a comment to the counter si I put a comment in the Thrift definition of num_row_errors which I thought would be more visible. I can move it here if you think that's better? http://gerrit.cloudera.org:8080/#/c/4985/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 430: // TODO: Refactor to reflect usage by other DML statements. > I think it makes sense to do this non-functional rename/refactoring in a se Ok I agree, I'll do it separately Line 445: // The latest observed Kudu timestamp reported by the KuduSession at this partition. > reported by the local KuduSession? Done -- To view, visit http://gerrit.cloudera.org:8080/4985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb1ad91dc355ea51de261c3a14df0f9d28c879c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
