Dan Hecht has posted comments on this change.

Change subject: IMPALA-3552: Make incremental stats max serialized size 
configurable
......................................................................


Patch Set 10: Code-Review+2

(2 comments)

Please hold off on committing until the blocker broken builds are fixed though.

http://gerrit.cloudera.org:8080/#/c/4867/10//COMMIT_MSG
Commit Message:

PS10, Line 21: amends the TBackendConfig
introduces a TBackendGflags


http://gerrit.cloudera.org:8080/#/c/4867/10/be/src/util/backend-gflag-util.cc
File be/src/util/backend-gflag-util.cc:

Line 76: }
it's too bad we can't autogenerate this file (and the thrift structure) so that 
new options are available to the FE automatically, but this is okay for now and 
definitely and improvement.


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: Yonghyun Hwang <[email protected]>
Gerrit-HasComments: Yes

Reply via email to