Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5035/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 568: true > why true? Prefer taking the lock when the method returns. There's a race there, if I take the lock after this call, the exec_state could have Done() called on it before I take the lock. But I looked at the code and it doesn't seem like Done() tears down the RuntimeProfile, so it should be valid as long as someone has a reference to the QES. I'll change it to false. -- To view, visit http://gerrit.cloudera.org:8080/5035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad8a1d6644259f177dfb3b29b3ba1ad6a76210a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
