Michael Ho has posted comments on this change. Change subject: IMPALA-4452: Always call AggFnEvaluator::Open() before AggFnEvaluator::Init() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5049/1/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 204: hash_tbl_->Insert(singleton_intermediate_tuple_); > no need to set output_iterator_ anymore? Yes as it was set unconditionally at line 236 below unless there is any error, in which case we won't need output_iterator_. -- To view, visit http://gerrit.cloudera.org:8080/5049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f261dee47821c517d8dbe1babf4112462d85807 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
