Henry Robinson has posted comments on this change.

Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not 
present
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5095/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

PS1, Line 153: If 
Undo this line break?


http://gerrit.cloudera.org:8080/#/c/5095/1/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java
File fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java:

PS1, Line 99: nstantiate HiveMetaStoreClient
connect to Hive MetaStore


PS1, Line 176: public void addClients(int numClients, int cnxnTimeoutSec) {
is this called elsewhere? If not, combine with initClients().


-- 
To view, visit http://gerrit.cloudera.org:8080/5095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I546d8fe9836004832ae40110c9fe22b3e704e11b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to