Internal Jenkins has submitted this change and it was merged. Change subject: clang-tidy should tidy tests; fix alignas error in clang builds. ......................................................................
clang-tidy should tidy tests; fix alignas error in clang builds. run_clang_tidy.sh was mistakenly using -notests, which doesn't even compile the tests, rather than -skiptests, which compiles (but does not run) the backend tests. When I discovered this, I also found that all clang builds (including tidy and asan) had been broken by my previous alignas commit (10a4c5a2e47ec7bf1e563b6a75d1bf2afb47ebd8). This patch fixes that as well. Change-Id: Ib7066039f78d7ee039db619b96e25665b4d63503 Reviewed-on: http://gerrit.cloudera.org:8080/5094 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Internal Jenkins --- M be/src/runtime/mem-pool.cc M bin/run_clang_tidy.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Internal Jenkins: Verified Sailesh Mukil: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7066039f78d7ee039db619b96e25665b4d63503 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]>
