Dan Hecht has posted comments on this change. Change subject: IMPALA-4493: fix string-compare-test when using clang ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5110/1/be/src/runtime/string-compare-test.cc File be/src/runtime/string-compare-test.cc: Line 34: EXPECT_EQ(stringcompare_r, 0); > Failures here would be easier to diagnose with the addition of " << l << ' EXPECT_EQ already prints its args (stringcompare_r), and the exact value of strncmp_r isn't interesting (only whether it is 0, neg, pos) which is implied by the EXPECT case. -- To view, visit http://gerrit.cloudera.org:8080/5110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d82ac2bff33fdbf66275fcfc6558c4bc29de5e7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
