Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5103/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: Line 260: // Number of row operations attempted but not modified due to errors reported by the > Suggest some minor rephrasing: Done http://gerrit.cloudera.org:8080/#/c/5103/2/shell/impala_shell.py File shell/impala_shell.py: Line 928: error_report = ", %d row error(s)" % (num_row_errors) > Don't we need to check somewhere whether num_row_errors was set in the resp Yes, this wasn't handled yet, thx. I added a test. -- To view, visit http://gerrit.cloudera.org:8080/5103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3d7aa8d176e03ea58fb00f2a81fb3e34965aa1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
