Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/5/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 445: /// Writes the next value into the next slot in the *tuple using pool if necessary. > ... into the destination slot in tuple ... Done Line 480: } else if (UNLIKELY(NeedsConversion() && > Is it possible that an otherwise invalid value becomes valid after conversi No, because the input to conversion must be a valid date. http://gerrit.cloudera.org:8080/#/c/4968/5/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: Line 512: /// the next slot in *tuple. > ... into the appropriate destination slot in 'tuple'. Done http://gerrit.cloudera.org:8080/#/c/4968/5/testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test File testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test: Line 5: DROP TABLE IF EXISTS invalid_parquet_timestamp; > setting up the table is already done in the .py file, right? Done -- To view, visit http://gerrit.cloudera.org:8080/4968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes