Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: PS15, Line 329: key Could do std:move() to avoid copy of string http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: PS15, Line 168: form from Line 214: /// Appends all rows in batch to the temporary Hdfs files their respective partitions. You're missing a verb in here I think Line 269: PartitionPair* current_clustered_partition_; "Only set if 'input_is_clustered_' is true" Line 272: /// batches. "Only set if 'input_is_clustered_' is true" -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
