Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: PS2, Line 617: kudu::client::DisableSaslInitialization(); > What guarantees that the Kudu client hasn't already initialized Sasl? Kudu won't init sasl until a kudu client is created and connects to a master. So this is safe, but it looks like this call actually returns an error status if that's the case. I'll add a comment handle that. -- To view, visit http://gerrit.cloudera.org:8080/5139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic465c31406a6df2753f6cc7481b6b391ed5e671b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
