Dan Hecht has posted comments on this change. Change subject: IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5129/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 379: converting from query_exec_state.end_time() > I hope the Navigator team doesn't have some crazy validation step to ensure Will do. http://gerrit.cloudera.org:8080/#/c/5129/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: PS1, Line 316: start_unix_ > Maybe rename to something that indicates what this field represents, e.g. q Went with start_unix_millis to shorten (thinking "query" is redundant with the fact that this is the QueryCtx, and "time" redundant with "unix millis"). http://gerrit.cloudera.org:8080/#/c/5129/1/tests/custom_cluster/test_lineage.py File tests/custom_cluster/test_lineage.py: PS1, Line 38: uery = """ > Is this comment relevant to the lineage test? Oops, mistakenly copied that over. Deleted. -- To view, visit http://gerrit.cloudera.org:8080/5129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34e435fc3511e65bc62906205cb558f2c116a8a9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
