Michael Ho has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4715/5/be/src/bufferpool/suballocator.h File be/src/bufferpool/suballocator.h: PS5, Line 66: Suballocations are eagerly coalesced when freed Is the coalescing only one level or does it recurse all the way up the tree until it cannot coalesce anymore ? What's the justification for coalescing eagerly ? Does it have a particular usage pattern in mind ? May help to document the design decision. Will FreePool() be stacked on top of it so it will keep its own free list on too ? -- To view, visit http://gerrit.cloudera.org:8080/4715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bfe0e429f67ad273f7c7d0816703a9e6c3da788 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
