Tim Armstrong has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5173/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1669: sessions_to_close = it->second; Not a big deal, but we could do a move() here to avoid the copy. -- To view, visit http://gerrit.cloudera.org:8080/5173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe37955027ad9fec3fdbbbcb199245c79bcac71 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
