Michael Brown has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5034/2//COMMIT_MSG Commit Message: PS2, Line 22: It's difficult to fully test the effects here. I made sure that we : generate syntactically valid queries still on the PostgreSQL side. > The code looks fine to me. I'm curious about this line in the commit messag Done -- To view, visit http://gerrit.cloudera.org:8080/5034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I149b695889addfd7df4ca5f40dc991456da51687 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
