Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4956/14/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: PS14, Line 475: avoid inlining avoid inlining for the exprs exceeding this threshold. Just noticed this change of behavior since PS7. This is not quite precise, right ? In fact, this is the maximum number of expression evaluation which will be inlined into a given function (e.g. EvalConjuncts). Any expression evaluations after the first CODEGEN_INLINE_EXPRS_THRESHOLD expressions will not be inlined but the first CODEGEN_INLINE_EXPRS_THRESHOLD may still be inlined, right ? This behavior seems a bit odd to me. It seems like the behavior of PS7 is more deterministic. With this approach, it's really unclear which expressions get inlined. -- To view, visit http://gerrit.cloudera.org:8080/4956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10015b49da182cb181a653ac8464b4a18b71091 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
