Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5267
to look at the new patch set (#3).
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
......................................................................
IMPALA-4550: Fix CastExpr analysis for substituted slots
During slot substitution, the type of the child of a CastExpr can
change. If the previous child type matched the CastExpr, then the cast
was flagged as noOp_. During substitution and subsequent re-analysis
the noOp_ flag was not revisited so that no cast was performed, even
after it had become necessary.
The fix is to always set noOp_ to the correct value in
CastExpr.analyze().
Change-Id: I7f29cdc359558fad6df455b8eec0e0eaed00e996
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5267/3
--
To view, visit http://gerrit.cloudera.org:8080/5267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f29cdc359558fad6df455b8eec0e0eaed00e996
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
