Jim Apple has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. ......................................................................
Patch Set 1: (2 comments) > (2 comments) > > Just wondering why we started hitting that ? Why isn't it showing > up in other Jenkins jobs ? I wish I knew. It hasn't showed up for me in my other Jenkins testing, or on my local machine. However, this handling is a mistake in any case, so this can hopefully downgrade the priority of this issue for me. http://gerrit.cloudera.org:8080/#/c/5242/1/tests/run-tests.py File tests/run-tests.py: PS1, Line 68: print >> sys.stderr, "run_tests arguments:", args > sys.stderr.write('Unexpected exception with pytest %s' % args) Done, using the format style recommended by https://docs.python.org/2/library/string.html PS1, Line 144: '\'' > Is this supposed to be \' instead ? In bash, in single-quoted strings, single quotes cannot appear - not even escaped! Instead, one must close the string, insert a literal single-quote (escaped, so bash doesn't think you're starting a new string), then start your single-quoted string again. -- To view, visit http://gerrit.cloudera.org:8080/5242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
