Tim Armstrong has posted comments on this change. Change subject: Start a docs build system. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile File docs/Makefile: > I considered it, but I thought for a build this primitive it would be best I guess my feeling is that make is quirky enough that it's not simple to learn and tricky to debug once you have non-trivial makefiles. It seems like it we could probably write an equivalent cmake file with add_custom_command, etc and it wouldn't be any more complex. I think it depends how much this is likely to grow. If it's going to get a lot more complex I'm in favour of avoiding make. If it's going to stay like this, make seems fine. -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9551b75268cb7cb29a58367a3ef03b127dccbfca Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
