Michael Ho has posted comments on this change. Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h File be/src/runtime/free-pool.h: Line 214: static AtomicInt32 alloc_counts_; > And initialize it? Default initialized to 0. Line 214: static AtomicInt32 alloc_counts_; > Also surround this with NDEBUG? Done -- To view, visit http://gerrit.cloudera.org:8080/5281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes