Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4303: Do not reset() qualifier of union operands. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4963/1/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java: Line 56: * Contains a query statement and the all/distinct qualifier adapt or remove that last sentence, which is redundant anyway. Line 61: // distinct propagation and unnesting that are needed after rewriting Subqueries. i don't understand the semantics of UnionStmt.reset() anymore. if we're trying to preserve the changes made during distinct propagation/unnesting, why are we resetting distinct-/allOperands_? can you describe the semantics of reset() succinctly? -- To view, visit http://gerrit.cloudera.org:8080/4963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157bb0f08c4a94fd779487d7c23edd64a537a1f6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
