Impala Public Jenkins has submitted this change and it was merged. Change subject: Fix undefined calls to __builtin_ctz. ......................................................................
Fix undefined calls to __builtin_ctz. GCC's __builtin_ctz[l[l]] functions return undefined results when the argument is 0. This patch handles that 0 case, which could otherwise produce results that depend on the architecture. Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe Reviewed-on: http://gerrit.cloudera.org:8080/5004 Reviewed-by: Jim Apple <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exprs/aggregate-functions-ir.cc M be/src/udf_samples/hyperloglog-uda.cc M be/src/util/bit-util.h 3 files changed, 45 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
