Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5302/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet.test:

Line 9: # IMPALA-4565: incorrect results because mt scan node does not set eos
> move this into mt-dop.test since it's not specific to Parquet and getting c
Done


Line 11: set disable_outermost_topn=true;
> I'm a little wary of having this test coverage depend on this 'exotic' quer
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48c50c8aa0c23710eb099fba252bc3c0cb74b313
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to