Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5162/7/tests/comparison/model_translator.py File tests/comparison/model_translator.py: Line 727: def _write_concat(self, func): Wasn't this in a separate review? http://gerrit.cloudera.org:8080/#/c/5162/7/tests/comparison/query.py File tests/comparison/query.py: PS7, Line 56: self.with_clause.table_exprs After thinking about this some more, we might need to make a copy here with list(self.with_clause.table_exprs). In InsertStatement.table_exprs, we do this: table_exprs += self.select_query.table_exprs Does the += operator call extend? -- To view, visit http://gerrit.cloudera.org:8080/5162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
