Michael Ho has posted comments on this change.

Change subject: IMPALA-4525: follow-on: cleanup error handling
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Sorry, didn't see this one until now.

http://gerrit.cloudera.org:8080/#/c/5212/3/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

PS3, Line 82: Status status = Status::OK();
Why not just Status status; ?


PS3, Line 138: for (int i = 0; i < expr_ctxs.size(); ++i) {
for (ExprContext* expr_ctx : expr_ctxs) {


-- 
To view, visit http://gerrit.cloudera.org:8080/5212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to