Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
......................................................................


Patch Set 1:

> I used this command to see the test simply runs the .test file with
 > codegen enabled and disabled.
 > 
 > impala-py.test --collect-only --workload_exploration_strategy
 > functional-query:exhaustive -k test_kudu_alter query_test/test_kudu.py
 > 
 > Are both query options needed for these tests?

 > I used this command to see the test simply runs the .test file with
 > codegen enabled and disabled.
 > 
 > impala-py.test --collect-only --workload_exploration_strategy
 > functional-query:exhaustive -k test_kudu_alter query_test/test_kudu.py
 > 
 > Are both query options needed for these tests?

Yeah that's a good question. I was thinking about only running w/ codegen 
enabled since it probably doesn't really matter for this test. However, I  
thought if the matrix grows in the future it could be an issue again. I'd be OK 
with limiting it & adding a comment, though.

Do you know how I can only run 1 of the 2 (e.g. just codegen enabled) for this 
particular test fn? I could always split it into a separate class and change 
the filters.

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

Reply via email to