Tim Armstrong has posted comments on this change. Change subject: IMPALA-4572: Run COMPUTE STATS on Parquet tables with MT_DOP=4. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5315/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 193: // unset or 0: single-threaded execution mode This isn't totally right. unset means 0 after we get past createExecRequest(), but before in the query options that are sent to createExecRequest(), it means something different. http://gerrit.cloudera.org:8080/#/c/5315/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: Line 231: Preconditions.checkState(ctx_.getQueryOptions().mt_dop > 0); This needs to be check if it's set too right? http://gerrit.cloudera.org:8080/#/c/5315/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: Line 1052: if (!queryCtx.request.query_options.isSetMt_dop() && It would simplify the rest of the code if we always set mt_dop to the effective value at this point, to avoid checking isset() everywhere. If I understood correctly, unset and 0 mean the same everywhere past this point, right? -- To view, visit http://gerrit.cloudera.org:8080/5315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2be3c7c9f3004e9a759224a2e5756eb6e4efa359 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
