Henry Robinson has posted comments on this change. Change subject: IMPALA-3875: Thrift threaded server hang in some cases ......................................................................
Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5263/3/be/src/runtime/client-cache.cc File be/src/runtime/client-cache.cc: PS3, Line 114: Status status = client_impl->socket_create_status(); if (!client_impl->socket_create_status().ok()) ? PS3, Line 115: goto error; Let's avoid goto unless it's the only good way to avoid very complex control flow. Here, you can just leave it as it was. -- To view, visit http://gerrit.cloudera.org:8080/5263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c8f91a88f723e0e58e81bb385c5a8f190021868 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
