Alex Behm has posted comments on this change. Change subject: IMPALA-3125: Fix assignment of equality predicates from an outer-join On-clause. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4986/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 1322: * whether it is correct to evaluate 'e' at a node materializing 'tids'. > rephrase as "returns true if..." Rephrased with "Returns false if ... Returns true otherwise." because that version is easier to express. Line 1331: * Checks whether 'e' originates from an outer-join On-clause, and if so, checks > same here Same as above. -- To view, visit http://gerrit.cloudera.org:8080/4986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719e0eeacccad070b1f9509d80aaf761b572add0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
