Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4982/2/testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-joins.test: Line 459: | | other predicates: a.tinyint_col < 10, b.tinyint_col > 20 why is this correct? this only applies to matches, so a non-match wouldn't need to satisfy this predicate. is there a good reason not to deal with all 'foreign' predicates (that only reference columns from other tables) by always evaluating them in the join where they originated? Line 892: # may not be assigned below the join materializing 'd'. are you saying it can be assigned to the join materializing d? Line 900: inner join functional.alltypes e are two joins/3 tables sufficient for this test case? -- To view, visit http://gerrit.cloudera.org:8080/4982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf45323ed9102ffb45c9d94a130ea3692286f215 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
