Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 139: kudu::client::KuduScanner::READ_AT_SNAPSHOT), "Could not set scanner ReadMode."); > rather than relying on the kudu default, do you think we should always call yeah I changed it to set it always, and flipped the polarity. I asked David and he thinks that Impala wouldn't want other read modes even if they're ever added. I guess it's possible for things to change, but not sure it's worth building in anything fancier now. -- To view, visit http://gerrit.cloudera.org:8080/5288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003aba410548bc9158d1e11abbdcf710c31a82ff Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
