Tim Armstrong has posted comments on this change. Change subject: IMPALA-4539: fix bug when scratch batch references I/O buffers ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5406/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 243: // The scratch batch may still contain rows, (or tuple ptrs if the legacy joins or > ... may still contain tuple data, (or ... Done Line 245: // cancelled at the wrong point. > remove "at the wrong point" Done Line 600: if (scratch_batch_->AtEnd() > Seems simpler to do this in TransferScratchTuples() when scratch_batch_->At We discussed offline and agreed that this fix was easier to reason about for now (since we'd have to duplicate the logic at two places in TransferScratchTuples()). -- To view, visit http://gerrit.cloudera.org:8080/5406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27e7251e0f633cb694b506f6eb62beed6e66ad9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
