Michael Ho has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions ......................................................................
Patch Set 3: Change looks good. There seems to be something similar in walltime.cc too so would be nice to clean them up too: https://github.com/apache/incubator-impala/blob/master/be/src/gutil/walltime.cc#L173 And something similar in util/os-util.cc -- To view, visit http://gerrit.cloudera.org:8080/5434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7237f579b201f5bd3930f66e9c2c8d700c37ffeb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: No
