Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests ......................................................................
Patch Set 2: Code-Review+1 I'm not going to stand in the way of progress, but for the record: - We have no root cause for the hang - We are removing test coverage - We have no plan of restoring the test coverage The fact that this test has not caught many failures is not necessarily an indication that it's useless. By that definition most tests would be useless. Think about what would happen if this became an accepted procedure for getting rid of "inconvenient" test problems. I concede this case might be an exception, just wanted to explain my general reluctance given the facts. I'm much more in favor of deleting code we don't need instead of leaving it and disabling it without understanding what is happening. -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd30abf8215415e0f2830b725e43b005daa2bb2d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
