Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files ......................................................................
Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/5400/4/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: Line 75: > Presumably you did this to prevent excessive logging, but I think its unnec Done http://gerrit.cloudera.org:8080/#/c/5400/4/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS4, Line 315: "Pa > Remove spaces, here and below. Done http://gerrit.cloudera.org:8080/#/c/5400/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS4, Line 319: 'NumScannersWithNoReads' counters ar > NumScannersWithNoReads Done PS4, Line 321: > Move """ to next line. Done PS4, Line 347: > num_scanners_with_no_reads Done PS4, Line 349: _name, r > executing Done PS4, Line 351: end up doing no reads. 'log_prefix' > num_scanners_with_no_reads Done PS4, Line 352: ers > Move to next line. Done PS4, Line 362: scanners_with_no_reads_list = re.fin > NumScannersWithNoReads Done -- To view, visit http://gerrit.cloudera.org:8080/5400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf48d978383d73efdade733a892e795ebd53c76a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
