Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op ......................................................................
Patch Set 2: Code-Review+2 (3 comments) Rebase, carry +2. http://gerrit.cloudera.org:8080/#/c/5449/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 797: * from that. > Expand the comment to mention that for S3 it always returns READ/WRITE acce Done PS1, Line 802: > nit: when referencing functions use parentheses (getPermissions()). Done PS1, Line 806: permissions, as that's what the S3A connector will always return too. : // TODO: Revisi > If there is a JIRA for this, can you add it here? Done -- To view, visit http://gerrit.cloudera.org:8080/5449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9d1072c185a6162727019cdf1cb34d7f3f1c75c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
