Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers ......................................................................
Patch Set 13: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4715/13/be/src/runtime/bufferpool/suballocator.h File be/src/runtime/bufferpool/suballocator.h: PS13, Line 173: Suballocation objects are owned by : /// either client code (if in use), the free list (if free) or its left child (if split). I think this could use calling out even more explicitly - the client has to hold onto a unique_ptr and the free list data is owned by the previous node of the array of free list unique_ptrs. -- To view, visit http://gerrit.cloudera.org:8080/4715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bfe0e429f67ad273f7c7d0816703a9e6c3da788 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
